chore: remove unused Localizable.xcstrings keys - #179
Merged
Conversation
"GET LTC" and "Set amount:" no longer appear anywhere in source (BuyReceiveView relayout renamed the buy button to "BUY LTC" and replaced the standalone "Set amount:" row with the preset chips / inline Custom entry), so their catalog entries were dead weight. Co-Authored-By: grunt-claude-bot <308083480+grunt-claude-bot@users.noreply.github.com> Co-Authored-By: kcw-grunt <mrkerrywashington@icloud.com>
kcw-grunt
approved these changes
Aug 22, 2026
kcw-grunt
added a commit
that referenced
this pull request
Aug 22, 2026
## Highlights since v3.9.16 - Reworked the Buy/Receive sheet (BuyReceiveView) to match the Android app's layout (#177) - Cleared remaining deprecated Security/Foundation API usage and a real infinite-recursion bug (#175) - Reduced the Swift compiler warnings list (#174) - Removed CircleCI — Xcode Cloud is now the sole CI (#173) - Updated Private/bw-gdlib to v1.6.9 (#171) and Modules/core (#176) - Restored the missing translations for COPY NEW ADDRESS, and added translations for BUY / RECEIVE and POWERED BY MOONPAY (21 locales each) — these existed in an earlier release attempt but were never merged back into develop (#184) - Removed 2 dead Localizable.xcstrings keys with no remaining source references: GET LTC, Set amount: (#179) - Fixed the auto-translate script writing Localizable.xcstrings with JSON formatting that didn't match Xcode's String Catalog serializer, which was rewriting every line of the file on every run and producing unreviewable, unmergeable translation PRs (#186) - Fixed the auto-translate workflow re-triggering on every push to any open PR (not just merges to main/develop), which was spawning duplicate translation PRs against long-lived branches (#190) - Picked up 42 additional previously-missing translations across 21 locales, generated cleanly after the above two fixes (#189) - Bumped MARKETING_VERSION to 3.9.17 ## Build CURRENT_PROJECT_VERSION bumped 2602309 -> 2602311. Co-Authored-By: grunt-claude-bot <noreply@grunt.ltd> Co-Authored-By: kcw-grunt <kerry@grunt.ltd>
Closed
kcw-grunt
added a commit
that referenced
this pull request
Aug 22, 2026
## Highlights since v3.9.16 - Reworked the Buy/Receive sheet (BuyReceiveView) to match the Android app's layout (#177) - Cleared remaining deprecated Security/Foundation API usage and a real infinite-recursion bug (#175) - Reduced the Swift compiler warnings list (#174) - Removed CircleCI — Xcode Cloud is now the sole CI (#173) - Updated Private/bw-gdlib to v1.6.9 (#171) and Modules/core (#176) - Restored the missing translations for COPY NEW ADDRESS, and added translations for BUY / RECEIVE and POWERED BY MOONPAY (21 locales each) — these existed in an earlier release attempt but were never merged back into develop (#184) - Removed 2 dead Localizable.xcstrings keys with no remaining source references: GET LTC, Set amount: (#179) - Fixed the auto-translate script writing Localizable.xcstrings with JSON formatting that didn't match Xcode's String Catalog serializer, which was rewriting every line of the file on every run and producing unreviewable, unmergeable translation PRs (#186) - Fixed the auto-translate workflow re-triggering on every push to any open PR (not just merges to main/develop), which was spawning duplicate translation PRs against long-lived branches (#190) - Picked up 42 additional previously-missing translations across 21 locales, generated cleanly after the above two fixes (#189) - Bumped MARKETING_VERSION to 3.9.17 ## Build CURRENT_PROJECT_VERSION bumped 2602309 -> 2602311. Co-Authored-By: grunt-claude-bot <noreply@grunt.ltd> Co-Authored-By: kcw-grunt <kerry@grunt.ltd>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes two dead entries from the String Catalog that no longer have any corresponding source reference after the BuyReceiveView relayout (#177):
"GET LTC"— the button was renamed to"BUY LTC""Set amount:"— the standalone label/row was replaced by the preset amount chips + inline "Custom" entryTesting
grep -rnacrossbrainwallet/)🤖 Generated with Claude Code
Co-Authored-By: grunt-claude-bot 308083480+grunt-claude-bot@users.noreply.github.com
Co-Authored-By: kcw-grunt mrkerrywashington@icloud.com